Tim Armstrong has posted comments on this change. Change subject: IMPALA-3105: rework handling of tuple buffer sizing in RowBatch ......................................................................
Patch Set 2: After looking at those functions and looking through the code again, I realise that several places may assume that the row batches have the capacity RuntimeState::batch_size(). I think I'm going to rethink the approach to make it a bit safer. -- To view, visit http://gerrit.cloudera.org:8080/2473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd9cd681875821c1c379d97586d3f4850aae622 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
