Tim Armstrong has posted comments on this change.

Change subject: Update LLVM to 3.7
......................................................................


Patch Set 1:

This version has some small perf regressions but I believe I have the major 
ones fixed. I ran a TPC-H benchmark with an older version of the patch and saw 
a couple of major regressions, which I've since fixed (it was missing some of 
the target machine setup so some optimisation passes didn't know what target 
they were optimising for).

I'll post updated perf results when I have a chance to run them:

        Cluster Name: UNKNOWN
        Lab Run Info: UNKNOWN
        Impala Version:          impalad version 2.5.0-cdh5.7.0 RELEASE 
(2016-02-24)
        Baseline Impala Version: impalad version 2.5.0-cdh5.7.0 RELEASE 
(2016-02-24)

        
+-----------+-----------------------+---------+------------+------------+----------------+
        | Workload  | File Format           | Avg (s) | Delta(Avg) | GeoMean(s) 
| Delta(GeoMean) |
        
+-----------+-----------------------+---------+------------+------------+----------------+
        | TPCH(_20) | parquet / none / none | 14.68   | +0.96%     | 10.06      
| +2.66%         |
        
+-----------+-----------------------+---------+------------+------------+----------------+

        
+-----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
        | Workload  | Query    | File Format           | Avg(s) | Base Avg(s) | 
Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters |
        
+-----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
        | TPCH(_20) | TPCH-Q1  | parquet / none / none | 23.24  | 19.47       | 
  +19.37%  |   0.72%   |   0.70%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q8  | parquet / none / none | 8.08   | 7.42        | 
  +8.90%   |   4.46%   |   1.35%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q6  | parquet / none / none | 3.96   | 3.69        | 
  +7.36%   |   2.84%   |   2.80%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q22 | parquet / none / none | 3.76   | 3.58        | 
  +4.86%   |   1.57%   |   1.30%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q14 | parquet / none / none | 4.85   | 4.64        | 
  +4.46%   |   2.25%   |   3.80%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q10 | parquet / none / none | 7.57   | 7.25        | 
  +4.44%   |   1.76%   |   1.04%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q9  | parquet / none / none | 16.83  | 16.13       | 
  +4.31%   |   0.95%   |   1.02%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q12 | parquet / none / none | 5.45   | 5.22        | 
  +4.31%   |   0.72%   |   1.22%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q2  | parquet / none / none | 3.72   | 3.59        | 
  +3.72%   |   1.66%   |   1.84%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q16 | parquet / none / none | 2.52   | 2.44        | 
  +3.42%   |   0.87%   |   2.00%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q18 | parquet / none / none | 18.54  | 17.99       | 
  +3.10%   |   4.03%   |   3.39%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q15 | parquet / none / none | 7.53   | 7.31        | 
  +2.99%   |   2.34%   |   2.85%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q11 | parquet / none / none | 2.79   | 2.74        | 
  +1.91%   |   2.13%   |   1.84%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q3  | parquet / none / none | 8.59   | 8.45        | 
  +1.64%   |   1.38%   |   1.43%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q19 | parquet / none / none | 65.44  | 64.42       | 
  +1.58%   |   1.65%   |   1.66%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q4  | parquet / none / none | 14.52  | 14.36       | 
  +1.11%   |   3.28%   |   1.28%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q20 | parquet / none / none | 8.93   | 8.88        | 
  +0.59%   |   1.51%   |   1.36%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q7  | parquet / none / none | 19.53  | 19.45       | 
  +0.45%   |   1.14%   |   1.95%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q13 | parquet / none / none | 15.38  | 15.34       | 
  +0.26%   |   0.48%   |   0.47%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q5  | parquet / none / none | 13.02  | 13.15       | 
  -0.97%   |   2.90%   |   2.79%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q21 | parquet / none / none | 38.12  | 38.69       | 
  -1.47%   |   1.03%   |   0.60%        | 1           | 10    |
        | TPCH(_20) | TPCH-Q17 | parquet / none / none | 30.66  | 35.77       | 
  -14.28%  |   1.01%   |   1.08%        | 1           | 10    |
        
+-----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+

-- 
To view, visit http://gerrit.cloudera.org:8080/2486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d7afd05ad3b472a0bfe035bfc3daada5597b2d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to