On 10 March 2016 at 08:14, Dan Hecht (Code Review) <[email protected]> wrote:
> Dan Hecht has posted comments on this change. > > Change subject: IMPALA-3162: Upgrade to gperftools 2.4 > ...................................................................... > > > Patch Set 2: > > > +Henry: Per the discussion about removing thirdparty, does it seem > > OK to make this change to use gperftools from the toolchain or > > should we wait until we've moved forward with removing thirdparty? > > I don't think we should wait. I think we should either: > a) move forward with this change with the understanding that building > without toolchain now requires manually adding some dependency. > b) add gperftools 2.4 to thirdparty > > either way, I think we should do this upgrade as soon as possible (once > well tested). > Is there any downside to adding gperftools to thirdparty? That seems like the path of least hassle, if we think we'll break someone who's not using the toolchain otherwise. Only reason I can see to wait is to see if 2.5 comes out in the next few days (since the second RC is out), but happy either way. > > -- > To view, visit http://gerrit.cloudera.org:8080/2509 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Ic06dd692c4c045db1275fca9c59e267c909599a3 > Gerrit-PatchSet: 2 > Gerrit-Project: Impala > Gerrit-Branch: cdh5-trunk > Gerrit-Owner: Matthew Jacobs <[email protected]> > Gerrit-Reviewer: Dan Hecht <[email protected]> > Gerrit-Reviewer: Henry Robinson <[email protected]> > Gerrit-Reviewer: Matthew Jacobs <[email protected]> > Gerrit-HasComments: No > -- Henry Robinson Software Engineer Cloudera 415-994-6679
