Internal Jenkins has submitted this change and it was merged. Change subject: Remove AMD Opteron Rev E workaround from atomicops ......................................................................
Remove AMD Opteron Rev E workaround from atomicops Impala doesn't run on Opteron Rev E because those CPUs don't support SSSE3. So let's not pay the price of this cmp/branch on the atomics path (which is used by our SpinLock, and I plan to make our Atomic class use these functions in a future change). Note that gperfutil also removed this RevE workaround since these CPUs are getting old and apparently many kernels don't have the workaround anyway. Let's call the init function for atomicops, even though it's basically a no-op for 64-bit mode (since these features are always available). But this future proofs the code a bit better. Change-Id: I3639dcf86c14778967c0079b8dbc222a4516cf05 Reviewed-on: http://gerrit.cloudera.org:8080/2516 Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/common/init.cc M be/src/gutil/atomicops-internals-x86.cc M be/src/gutil/atomicops-internals-x86.h 3 files changed, 3 insertions(+), 43 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3639dcf86c14778967c0079b8dbc222a4516cf05 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
