Tim Armstrong has posted comments on this change. Change subject: IMPALA-3045: Allow user defined package root. ......................................................................
Patch Set 1: Sorry I lost track of this CR. Agree that it's important to have a solution to this. So if I understand correctly, what the custom toolchain build job does now is: * checkout your custom branch of native-toolchain and executes ./build.sh with a list of packages and versions * native-toolchain/build.sh builds gcc then builds the requested toolchain packages * We then want to somehow build Impala with a mix of downloaded toolchain packages and custom toolchain packages. I'd prefer if this was implemented as a script that assembles a custom toolchain, then sets IMPALA_TOOLCHAIN before doing a normal Impala build. We should also make sure that the scripts to run the custom toolchain job are checked into version control and aren't just copied-and-pasted between jenkins jobs. -- To view, visit http://gerrit.cloudera.org:8080/2263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d5a76fcec0c6e50fbbbba05c25f9252e092c063 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
