Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3114: Add a pause monitor for impala processes. ......................................................................
Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/2405/4//COMMIT_MSG Commit Message: Line 10: every > not 'every', 'for' Done Line 11: 10seconds > 10 seconds (or just 10s) Done http://gerrit.cloudera.org:8080/#/c/2405/4/be/src/common/init.cc File be/src/common/init.cc: Line 75: > prepend PAUSE_ to make the association with the pause monitor clear. Done Line 83: scoped_ptr<impala::Thread> maintenance_thread; > static Done Line 85: A single : // thread is spawn that > just say 'The thread' Done Line 89: scoped_ptr<impala::Thread> pause_monitor; > static Done Line 141: while(true) { > space before ( Done Line 142: int64_t start = last_end_time; > I think you can just use one variable here: Done -- To view, visit http://gerrit.cloudera.org:8080/2405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04eca63c0c44fa8f1b78833080acdc2176372263 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
