Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3183: clang doesn't allow C files to have -std=c++14 ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/2540/1/be/src/gutil/dynamic_annotations.cc File be/src/gutil/dynamic_annotations.cc: Line 44: extern maybe add a 1line comment mentioning the deviation from the original copied from google? maybe helpful if we try to upgrade this code to a newer version from google later -- To view, visit http://gerrit.cloudera.org:8080/2540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dc8723214ec157aa7dc870d463294da4c754df2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
