Dan Hecht has posted comments on this change. Change subject: Add LLVM 3.8.0 to the toolchain ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2533/1/buildall.sh File buildall.sh: Line 72: # CentOS 5 can't build trunk LLVM due to missing perf counter so what do we do on CentOS 5? And wouldn't the same be true for RHEL5? http://gerrit.cloudera.org:8080/#/c/2533/1/source/llvm/build-3.7.x.sh File source/llvm/build-3.7.x.sh: Line 17: if this script will work for LLVM releases in general, maybe we should rename it? at least let's put a comment saying it's used to build 3.7.x and newer. -- To view, visit http://gerrit.cloudera.org:8080/2533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aa63741a5c6d8d4a5a36ba9471eba8799514ef1 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
