Taras Bobrovytsky has posted comments on this change. Change subject: Query gen: Add INSERT statements ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/2541/1/tests/comparison/db_types.py File tests/comparison/db_types.py: Line 150: return cls.CMP_VALUE + (100 * whole_digits + cls.MAX_DIGITS) / 10000.0 Can you add a comment about this? Where do the 100 and 10000 magic numbers come from? http://gerrit.cloudera.org:8080/#/c/2541/1/tests/comparison/discrepancy_searcher.py File tests/comparison/discrepancy_searcher.py: Line 529: query_generator let's rename this to statement_generator for consistency http://gerrit.cloudera.org:8080/#/c/2541/1/tests/comparison/model_translator.py File tests/comparison/model_translator.py: Line 400: sql = list() Why not start with an empty string? Line 406: for idx, col in enumerate(insert.cols): This looks a bit complicated, how about: sql.append(', '.join(col.name for col in insert.cols)) Line 415: sql.append('), (') It's kind of hard to follow this logic, I think it would be nicer to rewrite this with joins (similar to above) http://gerrit.cloudera.org:8080/#/c/2541/1/tests/comparison/statement_generator.py File tests/comparison/statement_generator.py: Line 22: class InsertGenerator(object): Is the idea to run the insert statement both on Impala and Postgres? Will the tables grow in size over time? -- To view, visit http://gerrit.cloudera.org:8080/2541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6110003789a4b6ae496c02a526c47c3249ef5307 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
