David Ribeiro Alves has posted comments on this change. Change subject: Review Only: Final Impala-Kudu merge ......................................................................
Patch Set 1: (4 comments) Addressed these items here: http://gerrit.cloudera.org:8080/#/c/2545/ http://gerrit.cloudera.org:8080/#/c/2536/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 96: print "renamed shit" > Lol Done Line 132: if check_for_existing_package(destination, pkg_name, pkg_version, compiler): > I thought the compiler stuff from line 135 needed to be done here too? Done http://gerrit.cloudera.org:8080/#/c/2536/1/common/thrift/Descriptors.thrift File common/thrift/Descriptors.thrift: Line 67: 11: optional CatalogObjects.TKuduTable kuduTable > What happened to 10? Done http://gerrit.cloudera.org:8080/#/c/2536/1/infra/deploy/deploy.py File infra/deploy/deploy.py: Line 4: # Confidential Cloudera Information: Covered by NDA. > Did you intend to commit this file? If so this line can be removed. Yes this is needed to generate a new Impala_Kudu service. Done -- To view, visit http://gerrit.cloudera.org:8080/2536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7d84ef583fc1d0ea2b656e3c0f41e9775a4659 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
