Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). ......................................................................
Patch Set 1: Adding functions to these files doesn't automatically expose them as built-in aggregate functions in Impala. You need to register the C++ functions in BuiltinsDb.java (see https://github.com/cloudera/Impala/blob/cdh5-trunk/fe/src/main/java/com/cloudera/impala/catalog/BuiltinsDb.java#L780 for an example). You'll need to provide the mangled symbol names of the functions, which you can find using the nm linux utility (e.g., nm $IMPALA_HOME/be/build/debug/exprs/libExprs.so | grep Corr). I suggest first making sure you can use your functions in the Impala shell. After this works, add some automated testing to https://github.com/cloudera/Impala/blob/cdh5-trunk/testdata/workloads/targeted-perf/queries/aggregation.test. To run these test cases, try something like the following: source $IMPALA_HOME/bin/impala-config.sh cd $IMPALA_HOME/tests ./run-tests.py query_tests/test_aggregation.py Feel free to email me if you run into problems. -- To view, visit http://gerrit.cloudera.org:8080/2534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7347c173ec4f80037d45dd463c17eb81ceef14a1 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Abdur Rafay <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: No
