Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3141: Send full filters when filter production is disabled ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2475/3/be/src/runtime/runtime-filter.h File be/src/runtime/runtime-filter.h: Line 201: bool IsFull() const { return HasBloomFilter() && bloom_filter_ == NULL; } > For a predicate-centric wording, how about "AlwaysTrue()"? that works. -- To view, visit http://gerrit.cloudera.org:8080/2475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b3e6542651c1e7b77a9bab01d0e3d9506af42f Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
