Michael Ho has posted comments on this change. Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/1901/8/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: Line 428: CodegenMemset > Not related to this change but just wondering why we never need one for mem Nevermind. Looks like llvm doesn't have an intrinsics for memcmp. Misread memcpy as memcmp. -- To view, visit http://gerrit.cloudera.org:8080/1901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib422a8d50303c21c6a228675157bf867e8619444 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
