Casey Ching has posted comments on this change. Change subject: IMPALA-3191: toolchain components should use toolchain cmake ......................................................................
Patch Set 4: Code-Review+2 (1 comment) Looks like the sles12 build passed. http://gerrit.cloudera.org:8080/#/c/2567/4/init.sh File init.sh: Line 158: if [[ "$OSTYPE" == "darwin"* ]]; then : build_fake_package "cmake" I wish Martin would have explained what he was doing here. Do you happen to know? From what I can tell cmake builds fine on OSX. Maybe he thought it was unnecessary. Having a consistent toolchain would be nice though. -- To view, visit http://gerrit.cloudera.org:8080/2567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a31098de42b4d5cb93c12bb2e054eadb8b8c72a Gerrit-PatchSet: 4 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
