Huaisi Xu has posted comments on this change.

Change subject: IMPALA-1702: Check all referenced tables, including those 
without associated TupleDescriptors, for duplicated table IDs.
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2570/3//COMMIT_MSG
Commit Message:

Line 7: IMPALA-1702: Check duplicated table ID for tables without associated 
TupleDescriptors
> "check all referenced tables, including those without associated TupleDescr
Done. But this commit is only about "for tables without associated 
TupleDescriptors" not "check all referenced tables, including.." but thanks for 
reviewing.. I am fine with anything..


Line 9: These tables can be the dest table in an insert statement.
> destination
Done


http://gerrit.cloudera.org:8080/#/c/2570/3/fe/src/main/java/com/cloudera/impala/service/Frontend.java
File fe/src/main/java/com/cloudera/impala/service/Frontend.java:

Line 1108:     List<Table> tablesToBeChecked = 
Lists.newArrayList(analyzer.getDescTbl().getReferencedTables());
> referencedTables
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2a6324cb9e28ba5be4bb525a639433ba3e8782b
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
Gerrit-HasComments: Yes

Reply via email to