Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2853: introduce RESOLVE_PARQUET_BY_NAME query option ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2384/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 2057: } > I think the thing that makes this function difficult to read is that all th lgtm, I'll change it. re: maps, the two fields in the file are supposed to be named "key" and "value", but due to legacy files we can't depend on it (see https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#maps). However, we could attempt to resolve the "key" and "value" fields by name in case they're switched, and then automatically fall back to resolution by ordinal if they don't resolve by name. I'll implement this but let me know if you have other thoughts on this. -- To view, visit http://gerrit.cloudera.org:8080/2384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0c715ea23792b2a6872610839a40532aabbb5a6 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
