Thomas Tauber-Marshall has submitted this change and it was merged. Change subject: IMPALA-1822: Cleanup query profile log ......................................................................
IMPALA-1822: Cleanup query profile log Implemented log rotation for the query profile log, to prevent it from growing unbounded, by adding log rotation to the SimpleLogger class. Previously, log rotation was only enabled for glog. It is still not enabled for audit event logging or lineage logging, but this should be simple to fix as they both use the same SimpleLogger class that the profile logging uses. There is a new flag, max_profile_log_files that controls how many of the most recent profile log files are retained. Change-Id: I52430d192d27cdf9bc0d81f26a63048eaeec5d29 Reviewed-on: http://gerrit.cloudera.org:8080/2260 Tested-by: Internal Jenkins Reviewed-by: Thomas Tauber-Marshall <[email protected]> --- M be/src/common/logging.cc M be/src/service/impala-server.cc M be/src/util/CMakeLists.txt A be/src/util/logging-support-test.cc M be/src/util/logging-support.cc M be/src/util/logging-support.h M be/src/util/simple-logger.cc M be/src/util/simple-logger.h 8 files changed, 187 insertions(+), 41 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52430d192d27cdf9bc0d81f26a63048eaeec5d29 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
