Dan Hecht has posted comments on this change. Change subject: Inject precision and scale constants for all decimal builtins ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/2535/11/be/src/exprs/expr.cc File be/src/exprs/expr.cc: Line 642: // All supported constants are currently integers. indentation glitch http://gerrit.cloudera.org:8080/#/c/2535/11/be/src/exprs/expr.h File be/src/exprs/expr.h: Line 450: GetIrConstant InlineConstants() -- To view, visit http://gerrit.cloudera.org:8080/2535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b7d1485f357ba88517ca15c5c7428c0ffe25dfd Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
