Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2531/5/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 250: TABLE_NAME = "parquet_annotate_utf8_test_%s" % random.randint(0, 10000) > Usually capital vars are class or module constants. I think you should make Done -- To view, visit http://gerrit.cloudera.org:8080/2531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I030c9f5c6272e09c1ce133f66234e3cfb26b68d4 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
