Michael Brown has posted comments on this change. Change subject: IMPALA-2904: Support INSERT and LOAD DATA on S3 and between filesystems ......................................................................
Patch Set 5: Also, is this review the time to consider a bit better file organization regarding tests/util , at least as it pertains to filesystem test code? While the particulars are up for debate, it might be good to create a tests/util/filesystem directory, and put common things, including this new base class, in common.py, and HDFS and S3-specific things in hdfs and s3 modules. I don't want to make that a blocker to this review, but I'd be curious to hear your thoughts. -- To view, visit http://gerrit.cloudera.org:8080/2574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e15ad67752dce21c9b7c1dced6e114905a942d Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
