Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2466: Add more tests for the HDFS parquet scanner. ......................................................................
Patch Set 1: (5 comments) I've added an extra test case. Sorry about the long delay. http://gerrit.cloudera.org:8080/#/c/1500/1/testdata/LineItemMultiBlock/LineItemSixBlocks/000000_0 File testdata/LineItemMultiBlock/LineItemSixBlocks/000000_0: > Can you update the README.dox to include these new files? Also consider ren Done http://gerrit.cloudera.org:8080/#/c/1500/1/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: Line 1781: DELIMITED FIELDS TERMINATED BY '|' > I don't think you need this for parquet tables Done http://gerrit.cloudera.org:8080/#/c/1500/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 210: def test_multiple_blocks(self, vector): > Can you refactor this and the below function into one helper function? It l Done Line 238: def test_verify_runtime_profile_one_rg(self, vector): > Rename test_multiple_blocks_one_rg for consistency with above test Done Line 243: TABLE_NAME = 'lineitem_multiblock_onerg' > nit: can you make this one_rg? onerg is a little hard to parse Done -- To view, visit http://gerrit.cloudera.org:8080/1500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4faccd9ce3fad42402652c8f17d4e7aa3d593368 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
