Dan Hecht has posted comments on this change.

Change subject: Add AtomicInt32/AtomicInt64 typedefs
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2601/2/be/src/common/atomic.h
File be/src/common/atomic.h:

Line 48: This class template should not be used directly; instead use the
       : /// typedefs below
> One possibility to consider is moving this to the 'internal' namespace. Tha
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b91ba684aabc67ed1721c7b7320aa42049268c8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-HasComments: Yes

Reply via email to