Jim Apple has posted comments on this change. Change subject: IMPALA-2973: Loosen bound on join timer test ......................................................................
Patch Set 1: > The idea seems OK in principle. Did you do any testing to come up > with 2000 and ensure it's a sufficient value? Note that I have > found discrepancies between code coverage build tests' timings on > CentOS 6 (Jenkins) vs. Ubuntu 14 (personal desktop), e.g., > IMPALA-2886 and IMPALA-2951, so local testing may not be enough. It > might be good to run a private code coverage build in Jenkins, if > you haven't already. I based the number on the bug reports, which show it being less than 2000 millis. -- To view, visit http://gerrit.cloudera.org:8080/2608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5598e073d779f744d79c5292e80a8ed8f6aa9548 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: No
