Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2605
to look at the new patch set (#2).
Change subject: IMPALA-3220: Skip logging empty ScannerContext's stream in
parse error.
......................................................................
IMPALA-3220: Skip logging empty ScannerContext's stream in parse error.
It's possible for a scanner thread to run to completion and call
ScannerContext::ReleaseCompletedResources() only to pick up a cancellation
or a bad status from the the runtime state in CommitRows(), both of which
are scan node wide's states instead of per-thread state. In this case, the
streams in the scanner context may have been removed already so it's unsafe
to access them when logging parse error. Instead, check if the streams still
exist in the scanner context before using them in logging.
Change-Id: Ic8e7ab10e62fff755a0acb9c5649d6a062217045
---
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/scanner-context.h
2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/05/2605/2
--
To view, visit http://gerrit.cloudera.org:8080/2605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e7ab10e62fff755a0acb9c5649d6a062217045
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
