Henry Robinson has posted comments on this change. Change subject: IMPALA-3141: Send dummy filters when filter production is disabled ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/2475/9/testdata/workloads/functional-query/queries/QueryTest/runtime_filters_wait.test File testdata/workloads/functional-query/queries/QueryTest/runtime_filters_wait.test: Line 32: join (select id FROM build UNION ALL select id + 100000 FROM build) b > does this query need to be so complicated? It would be easier to use tpch.lineitem here, but I want to make functional tests depend only on our functional database (doesn't make sense to have to load TPCH to run these tests). This is a bit simpler: select STRAIGHT_JOIN count(*) from alltypes a JOIN (select c.id from alltypes c CROSS JOIN alltypes d LIMIT 40000) b on a.id = b.id Is that preferable? -- To view, visit http://gerrit.cloudera.org:8080/2475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b3e6542651c1e7b77a9bab01d0e3d9506af42f Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
