Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-2650: UDF EE tests: use unique databases in some tests ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2610/2/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: Line 179: drop_fn_template = 'drop function if exists `{0}`.`%s`()'.format(unique_database) I think it's really weird to mix {0} and %s. How about putting {0} and (instead of %s) {1} in the template. Then below drop_fn_template.format(unique_database, old_function_name). Or is there a better way to do this in Python? -- To view, visit http://gerrit.cloudera.org:8080/2610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a8b4764fa310efaa4f6c6f06f64a4e18e44173 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
