Huaisi Xu has submitted this change and it was merged. Change subject: IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and HJ ......................................................................
IMPALA-2722: Free local allocations per row batch in non-partitioned AGG and HJ The fix of IMPALA-2612 added a test which verifies that the memory limit is not exceeded for the given query if local allocations are freed per processed row batch. The test fails when PHJ is disabled as the same bug (of missing free calls to local allocations) also exists in the non-partitioned counterpart of PAGG and PHJ. This change fixes both non-partitioned AGG and HJ nodes so local allocations are freed per row batch. Change-Id: I9aec4d1fb4f8d52fcdf67f1ca545efa698764f84 Reviewed-on: http://gerrit.cloudera.org:8080/1569 Reviewed-by: Matthew Jacobs <[email protected]> Reviewed-by: Tim Armstrong <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Reviewed-by: Marcel Kornacker <[email protected]> Tested-by: Internal Jenkins (cherry picked from commit ff75c9cde1f6554e7d7cef0b06af366eeabc0a1a) Reviewed-on: http://gerrit.cloudera.org:8080/2637 Reviewed-by: anujphadke <[email protected]> Tested-by: Huaisi Xu <[email protected]> --- M be/src/exec/aggregation-node.cc M be/src/exec/hash-join-node.cc 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Huaisi Xu: Verified anujphadke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aec4d1fb4f8d52fcdf67f1ca545efa698764f84 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]>
