Henry Robinson has posted comments on this change. Change subject: IMPALA-2888: StatestoreSslTest.SmokeTest failed ......................................................................
Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/2630/4/be/src/testutil/in-process-servers.cc File be/src/testutil/in-process-servers.cc: Line 46: int hs2_port = FindUnusedEphemeralPort(); how about checking the return value? http://gerrit.cloudera.org:8080/#/c/2630/4/be/src/util/network-util.h File be/src/util/network-util.h: Line 53: /// error. on an error? Or if it can't find a free ephemeral port after trying 10 times? If the caller thinks that -1 is an error it might behave differently than if it knows an ephemeral port can't be found. -- To view, visit http://gerrit.cloudera.org:8080/2630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51b7a2c609d3a5ae6f7d32ef38db89efe71a882b Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
