Henry Robinson has posted comments on this change. Change subject: IMPALA-3238: avoid log spam for very large hash tables ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2659/1/be/src/runtime/buffered-block-mgr.cc File be/src/runtime/buffered-block-mgr.cc: Line 311: if (!client->logged_large_allocation_warning_) { > I think LOG_FIRST_N is per-process so it would prevent the warnign from bei quite right, thanks for the correction. -- To view, visit http://gerrit.cloudera.org:8080/2659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366ce1148e83ac2eb71535d552bc68cb08388eec Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
