Internal Jenkins has submitted this change and it was merged. Change subject: Re-enable Kudu in build using client stubs when needed ......................................................................
Re-enable Kudu in build using client stubs when needed The stubs in Impala broke during the merge commit. This commit removes the stubs in hopes of improving robustness of the build. The original problem (Kudu clients are only available for some OSs) is now addressed by moving the stubbing into a dummy Kudu client. The dummy client only allows linking to succeed, if any client method is called, Impala will crash. Before calling any such method, Kudu availability must be checked. Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Reviewed-on: http://gerrit.cloudera.org:8080/2585 Reviewed-by: Casey Ching <[email protected]> Tested-by: Internal Jenkins --- M CMakeLists.txt M be/CMakeLists.txt M be/src/common/global-flags.cc M be/src/common/init.cc M be/src/exec/CMakeLists.txt M be/src/exec/data-sink.cc M be/src/exec/exec-node.cc M be/src/exec/kudu-scan-node-test.cc M be/src/exec/kudu-scan-node.cc M be/src/exec/kudu-scan-node.h M be/src/exec/kudu-scanner.cc M be/src/exec/kudu-table-sink-test.cc M be/src/exec/kudu-table-sink.cc M be/src/exec/kudu-table-sink.h M be/src/exec/kudu-util.cc M be/src/exec/kudu-util.h M bin/bootstrap_toolchain.py M bin/impala-config.sh M common/thrift/generate_error_codes.py M testdata/cluster/admin M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test M tests/common/impala_test_suite.py A tests/custom_cluster/test_kudu_not_available.py M tests/query_test/test_kudu.py 24 files changed, 187 insertions(+), 191 deletions(-) Approvals: Casey Ching: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]>
