Taras Bobrovytsky has posted comments on this change. Change subject: Fix Parquet timestamp behavior for Hive data ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/1681/9/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 781: UNLIKELY This should probably be removed. http://gerrit.cloudera.org:8080/#/c/1681/9/be/src/runtime/timestamp-value.cc File be/src/runtime/timestamp-value.cc: Line 102: time_zone_ptr timezone = TimezoneDatabase::FindTimezone(time_zone, *this); This gets executed for every value that we read. I think performance can be improved if we cache this value somewhere. Line 105: // local_date_time lt(date_, time_, timezone, local_date_time::NOT_DATE_TIME_ON_ERROR); I'll delete this line. -- To view, visit http://gerrit.cloudera.org:8080/1681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81e8e14d3ec9d399c26756914a54c552757dfbd2 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
