Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2384/7/be/src/service/query-options.cc File be/src/service/query-options.cc: Line 371: "0" > Why allow the numerical enum value? (Especially given that the enum is not I asked her to add this. It's because TQueryOptionsToMap ends up writing out the values as the enum values, so this allows us to parse it back. There are some cases (e.g. I think TQueryOptionsToMap sends the client those strings and then the client may end up sending them back) where that can be a problem if we don't handle it. -- To view, visit http://gerrit.cloudera.org:8080/2384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0c715ea23792b2a6872610839a40532aabbb5a6 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
