Alex Behm has posted comments on this change. Change subject: Fix start-impala-cluster.py with -s 0. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2666/2/bin/start-impala-cluster.py File bin/start-impala-cluster.py: Line 216: # No impalad instances should be started. Return to avoid division by zero below. > sorry to be a pedant, but really we're returning because there's no work to I disagree but don't want to argue about it. Looping over range(cluster_size) works naturally with the 0 value. But some part of the code does not work with zero, so we're forced to return early. Using your version. -- To view, visit http://gerrit.cloudera.org:8080/2666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9abe40de6c6caea26b6faa03b7495f25cb07e0ac Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
