Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/2580/7/fe/src/main/java/com/cloudera/impala/catalog/HdfsFileFormat.java File fe/src/main/java/com/cloudera/impala/catalog/HdfsFileFormat.java: Line 246: public boolean allowsQueryingScalarTypedCols() { > name could be slightly misleading when read out of context. how about: Done http://gerrit.cloudera.org:8080/#/c/2580/7/fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java File fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java: Line 190: if (slotDesc.isMaterialized() && > might be easier to read with: Done -- To view, visit http://gerrit.cloudera.org:8080/2580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a89b211bdc01f7e07497e293fafd75ccf0500fe Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
