Henry Robinson has posted comments on this change.

Change subject: IMPALA-3245: Fix crash with global filters when NUM_NODES=1
......................................................................


Patch Set 1:

That seems a little subtle. Perhaps it would be better to fix IMPALA-3305 
directly (where has_local_target is not always correct when NUM_NODES=1, 
because computeHasLocalTarget() is only called from the distributed planner).

That might trigger some bugs where the backend does not expect a filter to both 
be partitioned and local, hence this more direct fix. Agree that 3305 is 
probably worth closer inspection first.

-- 
To view, visit http://gerrit.cloudera.org:8080/2721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b9a6bcc64ca6ec5fd51d63815cea25de866ef93
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-HasComments: No

Reply via email to