Alex Behm has posted comments on this change.

Change subject: IMPALA-3269: Remove authz checks on default table location in 
CTAS queries
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2664/1/fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java
File fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java:

Line 826:     AuthzOk("create table tpch.new_table as select * from 
functional.alltypesagg " +
> Why did this test fail before your patch? Just want to make sure I understa
Discussed over chat. The reason is that we only check for URI permissions 
during a CREATE if there is an explicit location set. Otherwise, checking the 
DB permissions are sufficient, because the URI permissions under that DB are 
implied.


-- 
To view, visit http://gerrit.cloudera.org:8080/2664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0451586d4994cf9fc8c3dd47c8f3a513067cb2ea
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-HasComments: Yes

Reply via email to