Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2399: Memory limit checks for all scanners. ......................................................................
IMPALA-2399: Memory limit checks for all scanners. This change replaces all instances of MemPool::Allocate() in avro, text, hbase scanners with MemPool::TryAllocate(). HdfsAvroScanner::MaterializeTuple() has been converted to return a boolean in case of memory allocation failure. The codegen'ed version of MaterializeTuple() will also return a boolean. In the future, we should consider returning Status directly but that will be more involved and best left as a separate change. Change-Id: I3e5a56501967a58513888917db5ce66dec4fb5ce Reviewed-on: http://gerrit.cloudera.org:8080/2568 Reviewed-by: Michael Ho <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/base-sequence-scanner.cc M be/src/exec/data-source-scan-node.cc M be/src/exec/hbase-table-scanner.cc M be/src/exec/hbase-table-scanner.h M be/src/exec/hdfs-avro-scanner-ir.cc M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-avro-scanner.h M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-sequence-scanner.cc M be/src/exec/hdfs-text-scanner.cc M be/src/exec/hdfs-text-scanner.h M be/src/exec/scanner-context.cc M be/src/exec/text-converter.h M be/src/exec/text-converter.inline.h M be/src/runtime/string-buffer.h 16 files changed, 285 insertions(+), 128 deletions(-) Approvals: Michael Ho: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e5a56501967a58513888917db5ce66dec4fb5ce Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho <[email protected]>
