Casey Ching has posted comments on this change. Change subject: Add 10 minute timeout to all end-to-end tests ......................................................................
Patch Set 2: > Casey, I'm thinking that a time based timeout could cause > instability. Basically every test that relies on time is flaky, and > the timeout would add that to all tests. Also, if there is hang in > a test, then we might want to debug it live. > > What do you think? Just trying to continue the discussion on this > patch. If a timeout is used, the value should be high enough that it indicates that something was definitely wrong. For example a test that typically takes 10 seconds might have a 5 min timeout. The timeout is basically to prevent builds from hanging. About the live debugging, for a continuous integration system its probably best to keep things running automatically so no manual intervention is needed (clicking to abort a build in jenkins). Ideally everything needed to debug will be there in the logs and such. If people have a hard time repro'ing either locally or by spinning up a build slave manually, that should be made easier. -- To view, visit http://gerrit.cloudera.org:8080/1617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5d4d9b0363eed01b8f52e32a5a8c90592432a29 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-HasComments: No
