Casey Ching has posted comments on this change.

Change subject: Update python impala cluster script for docker compatibility
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1629/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:

Line 106:         if "uid not found" in str(e):
> Nit: PEP-008 prefers the "as"-style syntax of binding exceptions to identif
Ya but the code directly above does uses the same syntax. This seems like the 
kind of thing that should be done as a bulk update if wanted.


-- 
To view, visit http://gerrit.cloudera.org:8080/1629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ae7c4a5f3c6ce7d2838f9f722d5341c585cf562
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-HasComments: Yes

Reply via email to