Tim Armstrong has posted comments on this change.

Change subject: Remove conjuncts_passed arg in various Parquet scanner 
functions.
......................................................................


Patch Set 1: Code-Review+1

This was previously used when runtime filters were evaluated in the 
ColumnReader. When that was refactored this became dead code.

I suspect you'll have to change this again to add a different argument if you 
want to push down predicate evaluation to the columns but it seems fine to 
clean it up first.

-- 
To view, visit http://gerrit.cloudera.org:8080/2732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff511d6c4ba309eead6222701c17dee1b909a638
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to