Just fyi, corrected a typo in the commit msg with Gerrit (didn't realise you could do that!).
On 7 April 2016 at 22:23, Henry Robinson (Code Review) <[email protected]> wrote: > Hello Alex Behm, > > I'd like you to reexamine a change. Please visit > > http://gerrit.cloudera.org:8080/2734 > > to look at the new patch set (#2). > > Change subject: Kudu: Disable fsync in the mini-cluster > ...................................................................... > > Kudu: Disable fsync in the mini-cluster > > The Kudu team recommended disabling this for testing purposes. This > should help with timeouts in cloud machines (ec2/gce). If I > understand this correctly, disabling fsyncs could lead to data loss > if Kudu crashes while a write is in progress. But we'd have pretty > serious problems anyways because Kudu crashed. I'll confirm with the > Kudu team that a "normal" shutdown of Kudu should cause a sync. > > Change-Id: I72fd85ce5c4bc71f071b854ea6a9ebe60fc1305f > --- > M testdata/cluster/node_templates/cdh5/etc/kudu/master.conf.tmpl > M testdata/cluster/node_templates/cdh5/etc/kudu/tserver.conf.tmpl > 2 files changed, 2 insertions(+), 0 deletions(-) > > > git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/34/2734/2 > -- > To view, visit http://gerrit.cloudera.org:8080/2734 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: newpatchset > Gerrit-Change-Id: I72fd85ce5c4bc71f071b854ea6a9ebe60fc1305f > Gerrit-PatchSet: 2 > Gerrit-Project: Impala > Gerrit-Branch: cdh5-trunk > Gerrit-Owner: Casey Ching <[email protected]> > Gerrit-Reviewer: Alex Behm <[email protected]> > > -- > You received this message because you are subscribed to the Google Groups > "impala-cr" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/a/cloudera.com/d/optout. > -- Henry Robinson Software Engineer Cloudera 415-994-6679
