Sailesh Mukil has posted comments on this change.

Change subject: Kudu: Allow KUDU_IS_SUPPORTED to be overridden from the env
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2736/1/bin/impala-config.sh
File bin/impala-config.sh:

Line 91: if [[ -z "${KUDU_IS_SUPPORTED-}" ]]; then
Should we only check for KUDU_IS_SUPPORTED != false?
If KUDU_IS_SUPPORTED is manually set to true before executing this script, then 
none of the code inside this condition would be executed.


-- 
To view, visit http://gerrit.cloudera.org:8080/2736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b529c436418617b01c73bc917bfdf0a85c5440
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to