Taras Bobrovytsky has posted comments on this change. Change subject: Reuse session for executing queries (Hive on Spark) ......................................................................
Patch Set 2: (2 comments) Looks good, I added 2 minor suggestions http://gerrit.cloudera.org:8080/#/c/2374/2/tests/performance/query_exec_functions.py File tests/performance/query_exec_functions.py: Line 71: setattr(threading.current_thread(), 'cursor', cursor) I think it would be nicer to do this: threading.current_thread().cursor = cursor Line 72: get rid of this whitespace -- To view, visit http://gerrit.cloudera.org:8080/2374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c798dc311d63eb0a875450fd26d06db4e84a03 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kapil Rastogi <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Kapil Rastogi <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
