Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2805: Order conjuncts based on selectivity and cost ......................................................................
Patch Set 8: (4 comments) this is ready, once the perf regressions are addressed. please include the perf reports in the commit msg. http://gerrit.cloudera.org:8080/#/c/2598/8/fe/src/main/java/com/cloudera/impala/analysis/Expr.java File fe/src/main/java/com/cloudera/impala/analysis/Expr.java: Line 190: protected float evalCost_; set it to -1 here instead of default c'tor http://gerrit.cloudera.org:8080/#/c/2598/8/testdata/workloads/functional-planner/queries/PlannerTest/joins.test File testdata/workloads/functional-planner/queries/PlannerTest/joins.test: Line 174: | other predicates: a.tinyint_col = 15, b.string_col = '15', a.day >= 6, b.month > 2, a.tinyint_col + b.tinyint_col < 15, a.float_col - c.double_col < 0, (b.double_col * c.tinyint_col > 1000 OR c.tinyint_col < 1000) why did these change? http://gerrit.cloudera.org:8080/#/c/2598/8/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test: Line 1681: | hash predicates: d_week_seq = d_week_seq - 52, s_store_id = s_store_id why did this get flipped? i'd expect the store id comparison to be cheaper. what do the selectivities look like? http://gerrit.cloudera.org:8080/#/c/2598/8/testdata/workloads/targeted-perf/queries/conjunct_ordering.test File testdata/workloads/targeted-perf/queries/conjunct_ordering.test: Line 2: ---- QUERY: conjunct_ordering let's find a home for that in an existing test, this is too small to warrant a new file. -- To view, visit http://gerrit.cloudera.org:8080/2598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02279a26fbc6308ac5eb819d78345fc010469034 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
