Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem ......................................................................
Patch Set 15: (4 comments) You have to revert the following in your patch now: https://github.com/cloudera/Impala/commit/ed6a776377a3665b69bd6ce988522486e038dcc2 (I had to get this in quickly because our S3 builds were failing) You'll also need to handle the following: https://github.com/cloudera/Impala/blob/cdh5-trunk/testdata/bin/generate-schema-statements.py#L197 and this: https://github.com/cloudera/Impala/blob/cdh5-trunk/testdata/avro_schema_resolution/create_table.sql#L46 (There are 4 hardcoded "hdfs://" occurrences in this file) http://gerrit.cloudera.org:8080/#/c/1121/15/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: Line 424: configured defaultFS: I meant capital 'C' in the VLOG message, not the actual variable itself. The variable has to be in all lower case. http://gerrit.cloudera.org:8080/#/c/1121/15/bin/impala-config.sh File bin/impala-config.sh: Line 143: ${S3_BUCKET} Change this to just S3_BUCKET instead of ${S3_BUCKET} Line 151: / Let's remove the trailing '/'. You can see for HDFS and Isilon we don't keep it there. This could be a problem because the data warehouse is stored as '/test-warehouse'. Then we will end up with: 's3a://s3_bucket//test_warehouse' Which will not work on S3. Line 152: Single space -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 15 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
