Casey Ching has posted comments on this change. Change subject: IMPALA-3302: Fix ASAN use-after-free failure in Kudu scanner ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2749/1/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 270: DCHECK(slot->type().IsStringType()); > Right, but if we do support CHAR one day, it would be good to have this dch I don't really know what needs to be done for CHAR and I don't want to guess or look into it now (there are other priorities). If you happen to know the check you mentioned is correct, let me know and I'll change it. Otherwise this will be investigated when CHAR is added. -- To view, visit http://gerrit.cloudera.org:8080/2749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib513aae531086355e77ac9c35ed38728efaa0be9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
