Tim Armstrong has posted comments on this change. Change subject: Add TPC-H and TPC-DS ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/2719/4/source/tpc-ds/build.sh File source/tpc-ds/build.sh: Line 22: download_dependency $LPACKAGE "${LPACKAGE_VERSION}.zip" $THIS_DIR I actually renamed these variables in http://gerrit.cloudera.org/#/c/2658/ so you will need to rebase on that (assuming that my patch will go in first since it already got your +2). http://gerrit.cloudera.org:8080/#/c/2719/4/source/tpc-h/build.sh File source/tpc-h/build.sh: Line 22: download_dependency $LPACKAGE "${LPACKAGE_VERSION}.zip" $THIS_DIR See other comment about LPACKAGE Line 29: TCP tpc Line 32: # be done for all versions and the toolchain patch system isn't setup for that. The How do you mean all versions? How often does the tpch version change? Copying the patch directory if we upgrade the version doesn't seem too bad. Line 72: chmod +x "$LOCAL_INSTALL"/bin/dbgen Indentation seems off -- To view, visit http://gerrit.cloudera.org:8080/2719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf16c7979b5d0456c7b4c0c1bdf4a75853922f7 Gerrit-PatchSet: 4 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
