Alex Behm has posted comments on this change. Change subject: IMPALA-3270: Improve error message for unsupported data types ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2742/1/fe/src/main/java/com/cloudera/impala/analysis/CastExpr.java File fe/src/main/java/com/cloudera/impala/analysis/CastExpr.java: Line 213: if (!Type.getSupportedTypes().contains(type_)) { Minor stuff: - use type_.isSupported() for consistency - refactor type_.isSupported() to use the Type.supportedTypes() I'm thinking we should add this type check to TypeDef.analyze(). That way we'll also get the better error message in "most" appropriate places like CREATE/ALTER table, etc. You can see where TypeDef.analyze() is called to add tests for checking those places that now have a better error message. -- To view, visit http://gerrit.cloudera.org:8080/2742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0acb57d1749978143a3559ae676b882d4b018d58 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
