Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/1901/10/be/src/exec/topn-node-ir.cc File be/src/exec/topn-node-ir.cc: Line 32: insert_tuple->MaterializeExprs<false, false>(input_row, *materialized_tuple_desc_, > Not sure what you mean by two versions, are you referring to the second tem i get that, but why is that needed? why do you need two different bodies, in effect, for this function? -- To view, visit http://gerrit.cloudera.org:8080/1901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib422a8d50303c21c6a228675157bf867e8619444 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
