Tim Armstrong has posted comments on this change. Change subject: PREVIEW: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 325: continue_execution = ReadValue(pool, tuple); I think you could make these non-virtual calls without duplicating code by making a generic function ReadValueBatchImpl<typename ReaderType, bool IN_COLLECTION> that does a non-virtual call to ReaderType::ReadValue(). You could then instantiate a specialized version in each child class by calling it with the right template args e.g. ReadValueBatchImpl<ScalarColumnReader<IntValue>, IN_COLLECTION>(...) Kind of ugly but probably better than copy and paste. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
